[Github-comments] [geany/geany] WIP: Meson build system (#2761)

Eli Schwartz notifications at xxxxx
Tue Dec 7 21:48:44 UTC 2021


What is the purpose of running cp there at all? meson doesn't need it in order to trigger `install: true` -- you can just use `install_data(..., rename: 'new-name')`. And you don't save the custom_target in a variable and add it as an order dependency on another target, so if it actually needs to be present in the build tree then you have no guarantee it will be there.

Failing all that, ninja only runs the cp command when the input is newer than the output, you don't need cp to duplicate that check.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#issuecomment-988285954
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211207/303683e7/attachment.htm>


More information about the Github-comments mailing list