[Github-comments] [geany/geany] Update to Scintilla5 (#2867)

[Robert Di Pardo]

@rdipardo commented on this pull request.



> @@ -51,15 +54,15 @@
 #include "CharacterSet.h"
 #include "LexerModule.h"
 
-using namespace Scintilla;
+using namespace Lexilla;
 
 static inline bool IsNewline(const int ch) {
     return (ch == '\n' || ch == '\r');

Correct me if I'm wrong, but it seems the lexilla sources were pulled from [the rel-5-1-1 tag](https://github.com/ScintillaOrg/lexilla/commit/d83927f9794b5213ca52fc03c094b45feb87aeda).

If that's the case, you will want to patch in [this recent fix] for LexMarkdown; the v5.1.1 release contains [a bug that could hang the editor] if a user encounters it.

[this recent fix]: https://github.com/ScintillaOrg/lexilla/commit/68ff521b53fac828d07d234d330321cfec74699d#diff-d26e1c118bcc9f873c1d3ca41945d322461a32c74c9bcee689ea0d6cb714593eR59-R65

[a bug that could hang the editor]: https://github.com/ScintillaOrg/lexilla/issues/23

cf. https://github.com/geany/geany/issues/1439#issuecomment-896544368

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2867#pullrequestreview-732451180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210817/b9b2d6ab/attachment.htm>