[Github-comments] [geany/geany] Add reload all keybinding (#2859)

[elextr]

@elextr commented on this pull request.



> @@ -335,6 +335,21 @@ void on_toolbutton_reload_clicked(GtkAction *action, gpointer user_data)
 	document_reload_prompt(doc, NULL);
 }
 
+/* reload all files */
+void on_toolbutton_reload_all_clicked(GtkAction *action, gpointer user_data)
+{
+	guint i;
+	gint cur_page = gtk_notebook_get_current_page(GTK_NOTEBOOK(main_widgets.notebook));
+	
+	foreach_document(i)
+	{
+		if (! (documents[i]->file_name == NULL))

Right, that function is normally called by the response to reload on the file change detection info bar so it only happens one file at a time as you switch to the tab, so its less annoying.  Also the info bar doesn't show and the reload is automatic if the buffer is not changed since last save and `file_prefs.reload_clean_doc_on_file_change` is set.  So probably you could include that test before you called `document_reload_prompt()` to fully replicate the behaviour of the automated detection.

But it does beg the question why you need reload all since the automatic detection will do it as you switch to the tab?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2859#discussion_r684989460
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210809/e128bc59/attachment.htm>