[Github-comments] [geany/geany] Split geany.conf into geany.conf (preferences) and session.conf (recent files and VTE session) (#2776)

Thomas Martitz notifications at xxxxx
Tue Apr 6 11:12:48 UTC 2021


@kugel- requested changes on this pull request.

Almost. In principle I approve the change in the current state.

> @@ -628,34 +631,44 @@ static void save_ui_prefs(GKeyFile *config)
 	}
 }
 
+typedef enum ConfigPayload
+{
+	PREFERENCES,

Minor nitpick: Can you please shorten this to PREFS (and above PREFERENCES_FILE -> PREFS_FILE)? We usually refer to the configuration as "prefs" throughout the source and this would follow the pattern.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2776#pullrequestreview-628847906
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210406/bedcd055/attachment.htm>


More information about the Github-comments mailing list