[Github-comments] [geany/geany] Save As dialog can save the wrong document (#2599)

[elextr]

Yes, Geany is totally non-reentrant, thats why all dialogs are blocking, to stop users doing other things while they are open.  IIRC used to cause intermittent reports from KDE because the dialogs didn't block there.

Because the dialogs are blocking probably the socket operations are the only things that can cause reentrancy (well all I can think of just now :).  There is the potential for issues to happen anywhere Geany returns to mainloop while an operation is in progress, not just save as.

At least for save-as it might be fixed by getting the document to be saved before opening the save-as dialog so changing the current document won't affect which one gets saved.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2599#issuecomment-700339035
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20200928/4cbd918d/attachment.htm>