[Github-comments] [geany/geany] Disconnect signal handler from vte before destroying the widget. (#2634)

[Colomban Wendling]

After investigating the code, I don't think this can cause any harm, and it can indeed very well fix the mentioned issue.  I also have moved the `g_free(vf)` further down in 110b7c839b70c10cebed676434a5e4bef89b2dbc as if any callbacks is called in the destruction phase they would possibly use this freed pointer.  Also, it should have zero side effect apart from releasing memory a little later.

@elextr and here we go with the two last-minute commits for making a point release afterward :grin: 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2634#issuecomment-716053353
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201024/fe109756/attachment.htm>