[Github-comments] [geany/geany] Show OS info in debug messages (#2498)
Matthew Brush
notifications at xxxxx
Mon Oct 12 17:39:22 UTC 2020
> I would just leave it as it is - this is not something worth ifdefs or any extra code IMO.
Too late, I already created follow-up #2618, which puts it in a self-contained utils function, making the main code flow cleaner than in this PR and allowing support for older GLibs and MacOS/others. There was already `#ifdef` in there, now there's some more, which eventually will be able to mostly be removed. One could argue it's overkill for such a trivial "feature", but Geany's issue tracker has a chronic problem of people not reporting OS/version, so making that easier is, IMO, worth the extra `#ifdef`-ed code.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2498#issuecomment-707256404
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201012/a295db72/attachment-0001.htm>
More information about the Github-comments
mailing list