[Github-comments] [geany/geany] Ctags sync rebased (#2666)

[Colomban Wendling]

@techee actually I re-read @eht16 comments and I'm confused now.  I based my remark on

> No, the line endings of the input files don't matter. Tested with a C and SQL file (random choice) with LF and then again with CRLF line endings and the generated tags are the same.

But that is not coherent with what I understand of the filing tests a couple messages above.  So… I'm now just confused on what works and what doesn't.

At any rate I agree that we cannot simply change the input files so the tests pass, if these files are valid input files, we must accept them -- and as you say, we'd have the same issue with the internal buffer that does have the actual file's line ends.  I'll try to make a few tests with CRLF vs LF on my Linux box and see if the parser could choke on either, and possibly even try and craft "fake" Windows line end converter and see if it changes anything.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2666#issuecomment-735936506
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201130/38be4260/attachment.htm>