[Github-comments] [geany/geany] Search by entry text and preedit text (#2676)

[nimfsoft]

Hello. I am a Korean user.
Korean is different from Chinese and Japanese, so Korean users don't press a key such as `Space` to commit composing text explicitly.

Current geany searches by entry text on the `SearchEntry` because the signal `"changed"` of the `GtkEditable` or `gtk_entry_get_text()` can't get preedit text.

It is inconvenient for Korean users.
So I suggest that geany should search by entry text and preedit text on the `SearchEntry`.

![patched-searchentry](https://user-images.githubusercontent.com/75158510/100527892-53b76b00-321a-11eb-883d-e898494cc4af.png)

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2676

-- Commit Summary --

  * Search by entry text and preedit text

-- File Changes --

    M src/Makefile.am (2)
    M src/callbacks.c (15)
    M src/callbacks.h (3)
    M src/geanyentryaction.c (51)
    M src/geanyentryaction.h (5)
    A src/geanyentryactionprivate.h (41)
    M src/toolbar.c (9)

-- Patch Links --

https://github.com/geany/geany/pull/2676.patch
https://github.com/geany/geany/pull/2676.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2676
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201128/33d1138a/attachment.htm>