[Github-comments] [geany/geany] Ctags sync rebased (#2666)

[Jiří Techet]

At least for the tags file line ends, I'm starting to suspect it's us, not ctags. The newlines in tags files are written here:

https://github.com/geany/geany/blob/0a0b4b000cf18e837b921057a461ad05a08e41d3/src/tagmanager/tm_source_file.c#L528

and it's opened here in text mode:

https://github.com/geany/geany/blob/0a0b4b000cf18e837b921057a461ad05a08e41d3/src/tagmanager/tm_source_file.c#L596

At least from this:

https://stackoverflow.com/questions/58500480/why-does-printf-create-windows-line-endings

on Windows it seems `\n` produces CRLF. Would opening the file in binary mode help? The curious thing is that this isn't a new code in this patch so I don't understand how it could have worked before.

I think the rest of the failed tests will be caused by something similar in ctags.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2666#issuecomment-734731377
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201127/4a179acd/attachment.htm>