[Github-comments] [geany/geany] Ctags sync rebased (#2666)

[Colomban Wendling]

> The patch is not something too horrible, something like 80LOCs, but not some trivial one-liner so better to post it separaterly. Basically it just simply goes through the tags and renames the anonymous ones the way we need but in addition, we also have to update scopes where these tags are involved.

OK, I would have expected something like this indeed.  The only possibly worrysome part would be not missing any location that has to be updated, in case tag names get used some other places in the future.

> Updating upstream ctags is an option too, I was just worried about "polluting" ctags with things which are too specific for Geany use.

Sure, but maybe having more "readable" anonymous names is something that could benefit other consumers of ctags, even CLI ones.  There are other tools that use ctags to construct a TOC, and in a TOC I would argue that a readable name is somewhat better.  Though, maybe it's not so true because it's only useful when a human *looks* at the TOC, if the TOC is also used to jump to locations across files boundaries then they need to be unique again.
I'm kind of worried about how annoying it'd be to do, but maybe that's even something we'd like to do: transform anonymous names when displaying them, yet keeping a fairly unique internal name behind the scenes to avoid any clashes.  Well, that's just thoughts as they are coming :)

> And even if we kept the current few-line patch, it isn't a too terrible thing either.

Yeah it's no biggie, and we'll roll with that at least for now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2666#issuecomment-731852737
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201122/bf7fb0a9/attachment.htm>