[Github-comments] [geany/geany] Ctags sync rebased (#2666)

[Colomban Wendling]

> @b4n I had a brief look at the regex patches and they look good to me (haven't tried them though) - should I add them to this pull request?

If you're OK with them, yes, please.

> > ...we have a very minimal patch that would hopefully disappear one day...
> 
> I actually have a patch modifying our tag manager to achieve that - it's not completely trivial and maybe worth considering if we want to do it that way so I'll post it separately once this pull request is merged.

Depending on what the patch you're talking about involves, would you think upstream would accept a mean of selecting which method is used?  It actually could make sense to use their hash version when generating tag files so there's no (likely) duplicates, but use plain numbers when generating a TOC, so maybe there could be an option somehow.  Just a thought.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2666#issuecomment-731743205
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201122/1d59b87c/attachment-0001.htm>