[Github-comments] [geany/geany] Do not convert filename when opening files from command line on Windows (#2660)

Enrico Tröger notifications at xxxxx
Mon Nov 16 22:33:30 UTC 2020


This works if we use `g_locale_from_utf8()` instead of `utils_get_locale_from_utf8()` (the latter is just a no-op on Windows).
Just committed it but will try to add some more descriptive comments and commit message in the next days, so my future me won't wonder so much in the next 12 years :).

Thanks @b4n. The working directory is always UTF-8 on Windows which is OK enough. But I missed the case when the filename is non-ASCII and is locale-encoded as it is passed from argv.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2660#issuecomment-728370443
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201116/966d1774/attachment.htm>


More information about the Github-comments mailing list