[Github-comments] [geany/geany] Creating a user defined snippet config file produces a broken file by default (#2648)

Colomban Wendling notifications at xxxxx
Sun Nov 8 06:07:15 UTC 2020


> But basically if the toggle comment character is set to space the whole toggle comment feature is broken everywhere, not just here.

How so? It works fine when triggered, and leads to inserting what looks like a regular comment.
Using a marker that is not usually used allows to use the toggle comment feature to easily disable some part of the code without worrying about regular comments getting uncommented, but if your comments were using the marker you'd have the same problem, and if you didn't select commented lines you wouldn't have any problem either way.

> IIRC the discussions at the time, toggle comment was used so selected ranges can be uncommented easily in the resulting file without removing the original comments.

Fair enough, but we should make sure we only ever toggle *on*, e.g. consider all lines uncommented no matter what.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2648#issuecomment-723535605
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201107/8a06663b/attachment.htm>


More information about the Github-comments mailing list