[Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

Colomban Wendling notifications at xxxxx
Sat Nov 7 14:17:23 UTC 2020


@b4n commented on this pull request.



>  			fi
 		done
-		rmdir mingw32
+		rmdir mingw64
+	fi
+}
+
+delayed_post_install() {
+	if [ "$run_pi" ]; then
+		echo "Execute delayed post install tasks"
+		# Commands have been collected manually from the various .INSTALL scripts

This seems quite fragile to me, isn't it kind of risky to have to maintain that on our own?
Also, was running individual post-install script just too slow, or other problem?  One obvious solution if speed was not the issue but e.g. dependency order or something would be to run them all after (like, here).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2590#pullrequestreview-525655837
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201107/50506107/attachment.htm>


More information about the Github-comments mailing list