[Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

Colomban Wendling notifications at xxxxx
Sat Nov 7 13:06:30 UTC 2020


@b4n commented on this pull request.



> @@ -406,7 +406,7 @@ static gint get_windows_socket_port(void)
 	if (! g_file_test(configfile, G_FILE_TEST_IS_REGULAR))

This code could actually be simplified by basically having the same code path for the with and without config cases: just don't load the config if it doesn't exist, and then `utils_get_setting_integer()` will return the default.  But that's not for a point release.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2645#pullrequestreview-525651827
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201107/a112d976/attachment.htm>


More information about the Github-comments mailing list