[Github-comments] [geany/geany] WIP: Remove GTK+2 Support (#2602)

Colomban Wendling notifications at xxxxx
Mon Nov 2 20:14:53 UTC 2020


@b4n commented on this pull request.



> -		[enable_gtk2=$enableval],
-		[enable_gtk2=no])
-
-gtk2_package=gtk+-2.0
-gtk2_min_version=2.24
-gtk3_package=gtk+-3.0
-gtk3_min_version=3.0
-
-AS_IF([test "x$enable_gtk2" = "xyes"],
-	[gtk_package=$gtk2_package
-	 gtk_min_version=$gtk2_min_version],
-	[gtk_package=$gtk3_package
-	 gtk_min_version=$gtk3_min_version])
-
-AM_CONDITIONAL([GTK3], [test "x$gtk_package" = "x$gtk3_package"])
-

I would rather keep some skeleton of multiple GTK version support to make it easier to support e.g. GTK4 in the future, as mentioned in https://github.com/geany/geany/pull/2617#issuecomment-706535227

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2602#pullrequestreview-521960767
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201102/2616eb04/attachment.htm>


More information about the Github-comments mailing list