[Github-comments] [geany/geany] WIP: Remove GTK+2 Support (#2602)

[Colomban Wendling]

@b4n commented on this pull request.



> @@ -83,9 +83,9 @@
 #include <stdlib.h> /* only for atoi() */
 
 
+/* GTK3 removed ComboBoxEntry, but we need a value to differentiate combo box with and
+ * without entries, and it must not collide with other GTypes */

I'm open to a rewording, but I think it's important to have some kind of a comment here, because the reason for this is not so obvious I think.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2602#pullrequestreview-521643129
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201102/c0e3af8d/attachment-0001.htm>