[Github-comments] [geany/geany-plugins] Addons: doclist overflow menu corruption (#983)

[Enrico Tröger]

Thanks for the detailed report.
I cannot reproduce it with: `geany 1.37 (git >= ea649d80) (built on May 22 2020 with GTK 3.24.20, GLib 2.64.2)`.

Are there maybe additional steps required to trigger this, like opening something, using some menu item or anything like this?

Could you test if the following path would fix the error message?
```diff
diff --git a/addons/src/ao_doclist.c b/addons/src/ao_doclist.c
index a96a2f6e..f3bc1b81 100644
--- a/addons/src/ao_doclist.c
+++ b/addons/src/ao_doclist.c
@@ -112,10 +112,14 @@ static void ao_doc_list_finalize(GObject *object)
 {
 	AoDocListPrivate *priv = AO_DOC_LIST_GET_PRIVATE(object);
 
-	if (priv->toolbar_doclist_button != NULL)
+	if (priv->toolbar_doclist_button != NULL) {
 		gtk_widget_destroy(GTK_WIDGET(priv->toolbar_doclist_button));
-	if (priv->overflow_menu_item != NULL)
+		priv->toolbar_doclist_button = NULL;
+	}
+	if (priv->overflow_menu_item != NULL) {
 		gtk_widget_destroy(priv->overflow_menu_item);
+		priv->overflow_menu_item = NULL;
+	}
 
 	G_OBJECT_CLASS(ao_doc_list_parent_class)->finalize(object);
 }
```

It's just a wild guess that maybe the finalize() function is called twice.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/983#issuecomment-632727362
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20200522/87bcfeb4/attachment.htm>