[Github-comments] [geany/geany] Context menu update (#2550)

[Enrico Tröger]

> > the Addons plugin already has a similar feature (https://plugins.geany.org/addons.html#copy-file-path). The functionality is a menu item in the Tools instead of the notebook tab menu but additionally provides a keyboard shortcut.
> 
> I didnt even know that this wouldve been a feature! Although, of course to simply copying the full path is nice but at least in my experience you it being only one method and being buried in the `Tools` menu is rather unexpected when youve used other IDEs that have it on the Notetab (Notepad++, Atom, MonoDevelop, VS Studio iirc) is probably the first reason I didnt realize it. Reason number 2 is that by default my distribution doesnt inlcude the add-ons on the normal install (in the past it used to be one 

This argumentation could go for any plugin: harder to install, less obvious, ...
To be honest, following this argumentation we would not have any plugins and bloat the core with anything.


> > The functionality is a menu item in the Tools instead of the notebook tab menu but additionally provides a keyboard shortcut.
> 
> As far as keyboard shortcuts, @codebrainz did have us add Mnemonics so it's typically there. I had seen somewhere in the source-code yesterday that `Shift+F10` does open up the Notebook tab context menu this should allow the accelerator 

Ok, could work but needs a couple more keystrokes than a single shortcut.


> @eht16 I was initially going to suggest making this a plugin - being unaware of the addons feature - but:
> 
> * It's a very small, simple and common feature that seems to be appropriate as a core feature.
> * It would probably require more m4/bash/boilerplate code than [the entirety of the patch](https://patch-diff.githubusercontent.com/raw/geany/geany/pull/2550.diff).

Agreed on both.

> * The size of this context menu is already effectively unbounded.

I still think making the additional menu items configurable might be a good idea. But this can also be done separately, after this PR.

> That said, I'm indifferent. I won't merge unless there is consensus.

I don't mind much if the menu items go into core and not as plugin. In my first comment it was just a suggestion, not a definite requirement.

If it goes into core we should update the Addons plugin and remove the feature there and document it is now available in Geany itself. We should also add at least the keybinding which was offered by the plugin.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2550#issuecomment-660607070
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20200719/20642ea7/attachment-0001.htm>