[Github-comments] [geany/geany] Adds hidden preference 'always_set_from_selected' (default: FALSE) [...] (#2695)

Edgar notifications at xxxxx
Mon Dec 21 05:20:12 UTC 2020


> The name of the option always_set_from_selected suggested it was automatic, but having had a chance to look at the PR code it appears to only happen on ctrl-f (or whatever the search shortcut is set to).

Correct, the update of "Search phrase:" with the selected text only happens on the "reopen" event of the already visible dialog initiated by using the shortcut or menu _Search > Find..._ or _Search > Replace..._


> @etkaar also just noticed you made the changes in master, not in a branch, when you update can you please make the changes in a branch, that way committers can switch back from your changes to master or another set of changes easily.

Thanks for the note, I will try that!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2695#issuecomment-748763775
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201220/284dd22a/attachment.htm>


More information about the Github-comments mailing list