[Github-comments] [geany/geany] "make check" unittests fail on Windows (#2677)

[Jiří Techet]

> I still think reading the source files is not the problem. Tag parsing works fine on Windows, for LF and CRLF source files.

@eht16 I think we don't understand each other. We are trying to understand the results you got here:

https://gist.github.com/eht16/895090eddc23c6d241eb2cbec25159c0#file-test-suite-log-L91

For instance, you get this failure there

```
FAIL: ingres_procedures.sql
===========================

--- ./ingres_procedures.sql.tags	2016-06-12 17:16:40.683765400 +0200
+++ /tmp/tmp.2xGTegTO88/test.sql.tags	2020-11-25 23:33:27.945656500 +0100
@@ -1,7 +1,3 @@
 # format=tagmanager
 db0001Ì256Ö0
-db0002Ì256Ö0
-db0003Ì256Ö0
-errÌ16384Ö0
-nÌ16384Ö0
 xÌ16384Ö0
FAIL ingres_procedures.sql.tags (exit status: 2)
```

and the test fails not because of different line endings in the tags file, but because some real tags are missing in the output. From what I understood, when you change line endings from CRLF to LF in the test, this diff goes away. But then it means that the CRLFs in the test are the cause of the missing tags and there's some problem with parsing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2677#issuecomment-737771462
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20201203/607e73a9/attachment.htm>