[Github-comments] [geany/geany] Add 'Select to enclosing brackets' keybinding (#2264)

[elextr]

> but this command is called select enclosing brackets

But the first thing it says is `fixes #2260` so I expected it to do that.  Thats not to say that it isn't a useful command in and of itself, but it isn't the answer to #2260.

Where #2260 says:

> CTRL-b is a great shortcut, but i cannot select text to matching brace

That is the existing command `goto matching brace`, that is bound to `ctrl_b` by default.  Therefore the OP is asking for a version of that to select between the braces. Note that  `goto matching brace` does nothing unless a bracket is highlighted, it isn't `goto enclosing brackets`.  

So whilst your `select enclosing brackets` command is also a useful one because it works when the cursor is not beside the bracket, its not what was actually asked for in #2260.

As an example, if the cursor is beside a `{` of a C block, which is on a line by itself in the Geany code style, the brace is highlighted irrespective of which side the cursor is on and it seems unexpected to me as a user that the keybinding will select some outer block in the case that the cursor is before the `{` when its highlighted while the goto (ctrl-b) will goto the matching inner brace.

In the best case we should have both functions keybindable as required since they are both useful in different cases.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2264#issuecomment-533875248
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190922/6c2b5cf0/attachment.html>