[Github-comments] [geany/geany] Add 'Select to enclosing brackets' keybinding (#2264)

elextr notifications at xxxxx
Sat Sep 21 01:03:01 UTC 2019


Looks ok by inspection, not tested.

A couple of suggestions for improvement:

1. include `<>` if the `brace_match_ltgt` is set

2. the search for `]})` will find those characters in comments and strings so the selection is probably not what the user intended.  Not sure how to cure that though 3. will mitigate it somewhat.

3. check if the cursor is in a position where a pair of brackets are already highlighted and use that pair instead of searching

If you don't want to do these in this PR thats fine, please copy them into a future improvements issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2264#issuecomment-533754694
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190920/28976016/attachment.html>


More information about the Github-comments mailing list