[Github-comments] [geany/geany] build.c: enable the Next/Prev Error menu items only when there are build error messages (#2269)

elextr notifications at xxxxx
Sat Sep 14 22:17:59 UTC 2019


elextr approved this pull request.

Fixing when the menu items are enabled is fine, but this PR also includes changes not relevant to that and I am not seeing where the actual fix is.

> @@ -158,6 +158,9 @@ widgets;
 static guint build_groups_count[GEANY_GBG_COUNT] = { 3, 4, 2 };
 static guint build_items_count = 9;
 
+/* include the fixed widgets in an array indexed by groups */
+#define GBG_FIXED GEANY_GBG_COUNT

Would be better to define in the enum in the header, or if you don't want it in the enum at least next to it so all GBG_* declarations are in the same place.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2269#pullrequestreview-288337662
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190914/25a3a82e/attachment-0001.html>


More information about the Github-comments mailing list