[Github-comments] [geany/geany] filetypesprivate.h: Don't include build.h (#2299)

[Colomban Wendling]

b4n requested changes on this pull request.

I have to agree with @kugel- here: if the file uses a symbol defined in a header, it should include it. Manually introducing forward declarations should IMO be left to breaking circular dependencies alone.
Also, I don't know how it is on your machine, but here with a not-to-recent laptop, compilation time is not so bad I feel we need to resort to such workarounds.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2299#pullrequestreview-288309745
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190913/87b2dfc2/attachment.html>