[Github-comments] [geany/geany-plugins] lineoperations: add support for locale-aware sorting (#897)

[Sylvan Mostert]

smostertdev commented on this pull request.



> -#include "linefunctions.h"
+#include "lo_fns.h"
+#include "lo_prefs.h"
+
+
+/* Get sort function based on user preferences */
+lo_strcmpfns
+getcmpfns(void)
+{
+	if(lo_info->use_collation_compare)
+	{
+		return g_utf8_collate;
+	}
+	else
+	{
+		return strcmp;

For some reason I changed it a few years ago https://github.com/geany/geany-plugins/commit/2e2e043318fd2630cd05f1ee95c49fcdb019b6f7, I just don't remember why.

I agree with you, I think it is better with glib. I tested it and do not see any problems, so I'm not sure what I was thinking a few years ago.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/897#discussion_r321984902
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190907/007eaa1b/attachment.html>