[Github-comments] [geany/geany] Notebook tab menu: Move tab filenames to a button menu at end of tabs (#2348)

[Matthew Brush]

codebrainz commented on this pull request.



>  void notebook_init(void)
 {
+	GtkWidget *btn = gtk_button_new_with_label("☰");

> I read that "open-menu-symbolic" is the icon ...

Yeah, I think that's the one I was trying to remember. Depending on icon theme I think I've seen various images used such as three vertical dots or a gear as well.

> But that doesn't work on GTK2 with gtk_image_new_from_icon_name

It should work fine if you have this icon installed. If it's not commonly available, we could always ship a fallback icon like we do for the other non-standard ones we use.

> Seems like a font bug?

Nah, it's just because the font size is small so two of the lines are squished together making it look more like an equal sign than a list/burger. This is why an icon might be better, it doesn't depend on the user having their font size set large or having a proper Unicode font installed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2348#discussion_r336714475
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20191018/09b3a4e2/attachment-0001.html>