[Github-comments] [geany/geany-plugins] treebrowser: fix icons in the tree and the toolbar (#927)

Jiří Techet notifications at xxxxx
Sat Oct 12 21:59:26 UTC 2019


I noticed several problems with the tree browser:

1. The green toolbar icon with my theme corresponds to a document icon but it should be an action icon
<img width="479" alt="Screen Shot 2019-10-12 at 20 53 41" src="https://user-images.githubusercontent.com/713965/66708120-d9910200-ed4b-11e9-8c15-0cb73bf49861.png">
2. Expanded folder icon is wrong and corresponds to document open action icon instead of a file type icon
<img width="479" alt="Screen Shot 2019-10-12 at 20 54 03" src="https://user-images.githubusercontent.com/713965/66708125-fcbbb180-ed4b-11e9-86f9-e4d86157d969.png">
3. On MacOS folder icons are themed differently than e.g. ProjectOrganizer or File browser plugins.

This pull request addresses these issues and makes some cleanups of the code in addition.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/927

-- Commit Summary --

  * treebrowser: Use GIcon instead of pixbuf for tree icons
  * treebrowser: Use better icons
  * treebrowser: introduce a helper function and eliminate some #if's

-- File Changes --

    M treebrowser/src/treebrowser.c (192)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/927.patch
https://github.com/geany/geany-plugins/pull/927.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/927
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20191012/e4ab201d/attachment.html>


More information about the Github-comments mailing list