[Github-comments] [geany/geany-plugins] Overview: initialize color variables (#916)

[Colomban Wendling]

> 2. and if it did, the return_ifs can shortcut return and leave it uninitialised.

@elextr got a point, it's actually technically correct to say the value may not be initialized because of those checks, and it seem impossible for a tool to infer that those checks will succeed, even if we know they will -- unless something else went terribly bad and we're fubar.

So although I initially blamed that on cppcheck, I guess it's fair and this PR makes sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/916#issuecomment-538789763
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20191006/88360c00/attachment.html>