[Github-comments] [geany/geany-plugins] Overview: initialize color variables (#916)

[Matthew Brush]

> But or not I think setting a variable to a default is a good thing.

I haven't done a proper survey, but I'd wager if we did, we'd find hundreds if not thousands of uninitialized variables in Geany and GP's code.

> there is nothing to tell cppcheck that argument 2 is an out

If it did proper analysis (ie. look into callee) it would see it's passed to `memcpy` and fully written.

In any case, I'm fine with this PR if it shuts up `cppcheck`; this isn't performance critical in anyway, and it doesn't affect readability.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/916#issuecomment-538164617
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20191003/fa945629/attachment.html>