[Github-comments] [geany/geany] Make the shell used by Geany to run various commands configurable (#2363)

[Jiří Techet]

> One is not forced to zsh on macOS right? What should we do if the user doesn't use zsh but fish and only configures fish?

This is crazy. You first say you want to have only selected shells configurable

https://github.com/geany/geany/issues/2344#issuecomment-542627093

which I did to make you happy and then start talking about fish. If it were up to me, I'd let users specify whatever shell they want. I just went by the path of the least resistance and in that comment of yours it seemed you'd be fine with having only selected shells. Really, make up your mind what you want.

To all those comments about how dangerous things happen when you use a different shell, I can only say - show me. Here's the challenge for you: use Geany with this patch, select bash as the used shell and create .bashrc such that it satisfies these two conditions:

1. When this .bashrc is used from a terminal, you will be able to perform a build command without any problem.
2. When this .bashrc is used by Geany when running a build command, the build command will fail.

The last thing I want is to do Geany harder to maintain but unless you are able to prove your claims, I'm not convinced and I'm not going to continue this pointless discussion.

> Btw, I also find it curious that bash is started as a login shell. bash reads ~/.profile in a non-login shell so PATH/GOPATH should be setup there. I do wild things in my .bashrc that I deliberately do not want in non-interactive shells.

This is a bit screwed up on macOS. The thing is that the default terminal app which is part of the system runs the shell as a login shell and basically everyone else then follows this convention because people (or installers which add some command-line applications) typically update their `.bash_profile` instead of `.bashrc`.

> Does zsh read ~/.profile?

I think you are fixated on the "zsh vs bash" problem but the original problem @ruzgarmax was facing was "sh vs bash". Because Geany uses sh, it didn't read his .bash_profile where he (or some fortran installer) put his paths.

Anyway, to your question - this doesn't seem to be the case:

https://superuser.com/questions/187639/zsh-not-hitting-profile

> Do you know which solutions are available on wayland?

I don't know. But again, why not do the most obvious thing and let users specify the shell they want to use? Look at @ruzgarmax's reaction here:

https://github.com/geany/geany/issues/2344#issuecomment-542391753

Geany is used and should be easy to use by newbies. We shouldn't require that people reconfigure their system "the right way" and use 10 different config files. It should be easy to get Geany to the state where it behaves the same way as terminal. If problems like #2390 appear, we should just be able to say: "Ah, OK, go to settings and change the shell to /bin/bash and it will work". 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2363#issuecomment-551043771
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20191107/3ad296f5/attachment.html>