[Github-comments] [geany/geany] Always allow user filetype extensions to override system config file (#2166)

[Nick Treleaven]

Before the user would sometimes have to override `UnwantedFiletype=` in the user config file to remove an extension written in the system file. Geany would ignore an overridden filetype in the user config file that also matches the extension. This happened when the wanted filetype had a higher index than the unwanted one in `filetypes_array`.

This also first refactors the code without `filetypes_find` (which I wrote ages ago) - It's not worth abstracting finding through `filetypes_array`, it's not bug prone, and it may even cause bugs with non-type-safe predicate signature. It was only used once anyway.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2166

-- Commit Summary --

  * Kill filetypes_find(), rename static function
  * Always allow user filetype extensions to override system config file

-- File Changes --

    M src/filetypes.c (48)
    M src/filetypes.h (3)
    M src/filetypesprivate.h (1)

-- Patch Links --

https://github.com/geany/geany/pull/2166.patch
https://github.com/geany/geany/pull/2166.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2166
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190530/3191daf8/attachment.html>