[Github-comments] [geany/geany] FIX: filebrowser plugin: the first rightclick not working with some items on popup: (#2161)

[Matthew Brush]

codebrainz commented on this pull request.



> @@ -736,13 +739,9 @@ static gboolean on_button_press(GtkWidget *widget, GdkEventButton *event, gpoint
 	}
 	else if (event->button == 3)
 	{
-		static GtkWidget *popup_menu = NULL;

While I dislike static local (or global) variables which allocate memory dynamically and never cleanup, moving this one to the global scope seems completely unrelated to this change. Or did I miss it being used elsewhere?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2161#pullrequestreview-240944637
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190522/10f21256/attachment.html>