[Github-comments] [geany/geany] The very last manual ctags/main sync (I promise) (#2132)

[Matthew Brush]

codebrainz commented on this pull request.



> @@ -44,7 +44,6 @@ AC_CHECK_HEADERS([fcntl.h glob.h stdlib.h sys/time.h errno.h limits.h])
 # Checks for dependencies needed by ctags
 AC_CHECK_HEADERS([fnmatch.h direct.h io.h sys/dir.h])
 AC_DEFINE([HAVE_STDBOOL_H], [1], [whether or not to use <stdbool.h>.])
-AC_CHECK_HEADERS(dirent.h,have_dirent_h=yes)

I only looked at this one teeny part, but `dirent.h` is still included in `main.c` in Geany and upstream. Is the intention to just permanently guard out it's inclusion via `HAVE_DIRENT_H` never being defined? Feel free to ignore me, it just looked funny.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2132#pullrequestreview-240908572
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190522/6571e5af/attachment.html>