[Github-comments] [geany/geany] Default to wrap and find when the string was not found (#1192)

[Matthew Brush]

We shouldn't hijack this issue, it's literally just to change the default button on the wrap search dialog which would most likely be an acceptable change if someone does it.

Probably the approach would be to add another argument to [`dialogs.c::show_prompt()`](https://github.com/geany/geany/blob/868da11715ed86d08c1c2c4deaf1b2aa6c209df4/src/dialogs.c#L1295) and friends which tells the default button, so it can be passed via wrapper functions in [`document.c::document_find_text()`](https://github.com/geany/geany/blob/868da11715ed86d08c1c2c4deaf1b2aa6c209df4/src/document.c#L2374).

Alternatively it might be easier to just create an ad hoc dialog normally at the call site and set it up as needed, to avoid affecting all the callers of `dialogs_show_question_full()` and friends.

> It does here and AFAICT that was part of 1.32

That's "Find Usages", not the regular find/search.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1192#issuecomment-494656249
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190521/09993fa5/attachment-0001.html>