[Github-comments] [geany/geany-plugins] autoclose: fixed deprecated gtk call for gtk3 (#857)

LarsGit223 notifications at xxxxx
Sun May 12 17:19:28 UTC 2019


This fixes a deprecation warning in the autoclose plugin for gtk3. No functional changes.

A little side note:
I first thought I could use ```gtk_container_add()``` on gtk 2 and 3 because of this deprecation notice in the gtk documentation:

> gtk_scrolled_window_add_with_viewport has been deprecated since version 3.8 and should not be used in newly-written code.
> gtk_container_add() will automatically add a GtkViewport if the child doesn’t implement GtkScrollable.

But the function only works that way under gtk3. A test with gtk2 revealed that the function does not work that way with the result that in this case the scroll bar was missing in the autoclose configuration dialog.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/857

-- Commit Summary --

  * autoclose: fixed deprecated gtk call for gtk3

-- File Changes --

    M autoclose/src/autoclose.c (4)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/857.patch
https://github.com/geany/geany-plugins/pull/857.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/857
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190512/bbb31fd3/attachment.html>


More information about the Github-comments mailing list