[Github-comments] [geany/geany] add gcc 7 and 8 build to travis tests (#2067)

[Colomban Wendling]

b4n commented on this pull request.



> @@ -25,10 +95,15 @@ install:
   - sudo apt-get install -y python-lxml
 before_script:
   - export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=implicit-function-declaration"
+  - if [ "$TRAVIS_COMPILER" = "clang" ]; then
+      CFLAGS="$CFLAGS -std=c++11";
+    fi

don't do that, `configure` is responsible for this kind of stuff, and it should be doing it alright.  And if it ain't, it might be worth fixing it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2067#pullrequestreview-234783030
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190507/8b37c82d/attachment-0001.html>