[Github-comments] [geany/geany] NSIS upgrade to 3.x (#2181)

[Colomban Wendling]

b4n requested changes on this pull request.

Apart from the one comment, LGTM

> @@ -39,8 +39,7 @@ variables=$(\
 variables_extra='{nsisdir} 0 1 2 3 4 5 6 7 8 9 r0 r1 r2 r3 r4 r5 r6 r7 r8 r9 \\n \\r \\t $'
 variables="${variables_extra} ${variables}"
 # prefix each element with a dollar sign
-declare -a variables_array=(${variables})
-variables="${variables_array[@]/#/'$'}"
+variables="$(echo $variables | sed 's/[^ ]*/$&/g')"

you should quote `$variable` to avoid any unexpected things happening.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2181#pullrequestreview-252243276
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190620/4602034f/attachment.html>