[Github-comments] [geany/geany] Highlight string escape sequences in LexCPP filetypes (#2157)

[Colomban Wendling]

> Instead of `string_2` I've made string escapes use `string_1,bold`.

I'm not sure forcing a style attribute is a good idea, as it won't have any effect if the base style has it already.  Also bold specifically apparently sometimes cause issues with some poor fonts that get emulated boldness that lead to not truly fixed width characters, and so I heard more than once people wanting to get rid of it.

What about adding a new style altogether, and provide a reasonable default using another named style?  e.g. introduce `string_escape_1=string_1` and themes can override this to something else.  I didn't check if we can currently do that, but it sounds better to me than try and fit one of the styles we already have that don't really make semantic sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2157#issuecomment-503751087
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190619/6964898e/attachment-0001.html>