[Github-comments] [geany/geany] Don't unnecessarily ask whether to close current project (#2178)

Nick Treleaven notifications at xxxxx
Sat Jun 8 16:40:15 UTC 2019


When using New Project/Open project dialogs or the recent project files submenu, there's no need to confirm closing the project (so long as the dialogs can be cancelled before closing the session). It's unlikely those actions are done by accident. I've kept confirmation for opening a project file from the command line, in case it was a glob mistake. OSX confirmation is kept because I'm not sure what the OSX code is for and also can't test.

* Make Open Project dialog cancellable without closing existing session
* Opening recent projects: Don't ask whether to close current project
* Make New Project dialog cancellable without closing existing session (this one needed some refactoring)

These 3 are in separate commits, probably best to view commits separately.
This also probably makes #2171 unnecessary.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2178

-- Commit Summary --

  * Make Open Project dialog cancellable without closing existing session
  * Make New Project dialog cancellable without closing existing session
  * Opening recent projects: Don't ask whether to close current project

-- File Changes --

    M src/project.c (91)
    M src/ui_utils.c (3)

-- Patch Links --

https://github.com/geany/geany/pull/2178.patch
https://github.com/geany/geany/pull/2178.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2178
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190608/a3285f05/attachment.html>


More information about the Github-comments mailing list