[Github-comments] [geany/geany] Replace search dialog with search bar (#2220)

[Colomban Wendling]

The idea looks quite neat, but bear in mind that
* translated strings are often fairly different in length than English ones.  If this could be a problem, we'll need different translations for the toolbar, but bear in mind that it's sometimes very awkward to shorten a translation, so width of the text should not be too important (e.g. here "match case" would be "sensible à la casse" in French, and it's tricky to get something shorter that still reads easily).
This suggests the widget layout should not be fixed, and possibly if really useful, use a different translation context.
* this search bar does not support the "find all" part of the search dialog, and it probably would be awkward for it to include it if it's visually part of the document's tab.  Meaning that we'll "always" need the dialog for this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2220#issuecomment-512812294
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190718/bc61fe1c/attachment.html>