[Github-comments] [geany/geany] Keep an invalid document in documents[0] (#247)

Colomban Wendling notifications at xxxxx
Thu Jul 11 18:34:38 UTC 2019


b4n commented on this pull request.

Looks fine

> @@ -383,6 +381,10 @@ GeanyDocument *document_get_current(void)
 void document_init_doclist(void)
 {
 	documents_array = g_ptr_array_new();
+#ifdef GEANY_DEBUG
+	// add a dummy invalid document to catch naive iteration
+	g_ptr_array_add(documents_array, g_new0(GeanyDocument, 1));

If I'm not mistaken you could simply use `new_doc_index()` now

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/247#pullrequestreview-252108943
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190711/b02271b2/attachment.html>


More information about the Github-comments mailing list