[Github-comments] [geany/geany] Show variable type in a tooltip in symbol tree (#2036)

[Jiří Techet]

techee commented on this pull request.



> @@ -908,6 +908,18 @@ static gchar *get_symbol_tooltip(GeanyDocument *doc, const TMTag *tag)
 {
 	gchar *utf8_name = editor_get_calltip_text(doc->editor, tag);
 
+	if (!utf8_name && tag->var_type &&
+		tag->type & (tm_tag_member_t | tm_tag_variable_t | tm_tag_externvar_t))

Yeah, this was to make sure these are only variable-like tags but I forgot tm_tag_field_t which I've just added. Maybe these checks aren't completely necessary because varType won't be set for anything else than functions and variables but if anything else, it makes it more clear in the code what we are doing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2036#discussion_r245828761
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190107/bf16f7a1/attachment.html>