[Github-comments] [geany/geany] Add Nim filetype (#2085)

[Colomban Wendling]

b4n requested changes on this pull request.

Looks reasonable, but do we want Nim builtin?  I don't mind, but for not very widespread languages that only need/have a custom filetype, we often just have a [wiki page](https://wiki.geany.org/tag/filetype?do=showtag&tag=filetype).  However, if the filetype is of sufficient quality I guess we can have it in, especially as I read a few mentions of Nim lately here and at Universal-CTags so it might be gaining popularity.

> +
+primary=addr as asm atomic bind block break case cast const continue converter defer discard distinct div do elif else end enum except export finally for from func generic if import include interface iterator let macro method mixin mod notin object of out proc raise return shl shr static template try type using var when while with without yield seq array tuple ref ptr not and xor in or is isnot new result
+
+identifiers=bool float int string nil true false echo
+
+[settings]
+
+extension=nim
+comment_single=#
+comment_use_indent=true
+tag_parser=Python
+lexer_filetype=Python
+
+[lexer_properties]
+styling.within.preprocessor=1
+lexer.cpp.track.preprocessor=0

Those two seem irrelevant in case of the Python lexer, aren't they?

> +[settings]
+
+extension=nim
+comment_single=#
+comment_use_indent=true
+tag_parser=Python
+lexer_filetype=Python
+
+[lexer_properties]
+styling.within.preprocessor=1
+lexer.cpp.track.preprocessor=0
+
+[indentation]
+
+width=2
+type=0

Is this required by the NIM language?  We prefer to not force indent type on people unless it's a requirement of the language (e.g. tabs for Makefiles).  If it's the official recommendation, it's fine to provide those commented-out.

> @@ -0,0 +1,34 @@
+# For complete documentation of this file, please see Geany's main documentation

This file needs to be added to *data/Makefile.am*

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2085#pullrequestreview-201855022
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190209/2f4590cb/attachment.html>