[Github-comments] [geany/geany] Reflow Lines/Block incorrectly treats long line marker (#2078)

[elextr]

> But with disabled line breaking, manual reflow limits lines to 69 characters.

Yes because its using a setting that has a value that is one smaller.

> As a user, I expect Reflow with disabled Line Breaking to wrap lines _longer than_ the marker's X as well, but instead it wraps _at_ X. That's rather strange and inconvenient.

I have to say I find it simple and consistent, line breaking always behaves the same, it breaks __at__ the specified column, always, no matter what, thats being consistent.  Long line functionality marks __after__ the specified column.

Note the two different emphasised words in the paragraph above, the two functions are different so of course they don't align.

Line breaking is a per document setting, it can be turned on and off for any document, but the settings are session wide.  Suddenly having manual reflow happen at a different place because automatic line breaking is turned on for one document and off for another, even when the settings are the same number would be confusing and wrong.

Perhaps reflow should only ever use the line breaking setting, even if automatic breaking is off.  That way the two functions are totally independent and internally consistent with themselves, instead of the same number (long line) being used in two different ways by two different functions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2078#issuecomment-460648377
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190205/7c06e25f/attachment.html>