[Github-comments] [geany/geany] Setting SciTEGlobal properties (#2068)

elextr notifications at xxxxx
Tue Feb 5 04:52:25 UTC 2019


@andy5995 Ahh, well, yeah, finding them is the issue!!

The problem is that its not all in the one place I'm afraid, for example some are set in [editor.c::create_new_sci()](https://github.com/geany/geany/blob/bf5c9eddd8a500577719af7fc7f1c1ffb8044a49/src/editor.c#L4900) but the margin widths as mentioned in the OP are hard coded [here](https://github.com/geany/geany/blob/bf5c9eddd8a500577719af7fc7f1c1ffb8044a49/src/sciwrappers.c#L149) and I bet there are other places in that file where values are hard coded that could be variable.

And of course there are places where Geany doesn't set a value at all, relying on the Scintilla default, you would have to find those from the Scintilla docs.  Using find-in-files on all of Geany should help.

Probably best to create an issue and list those that you find, and if you think they make sense to be variable. That way others can provide any advise they are aware of, such as "No that will conflict with XXX".

But then do them one at a time by pull request so they are simple and (hopefully) fast to merge.  Large pull requests tend to sit because reviewers and committers are short of time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2068#issuecomment-460512432
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190204/4f6504a9/attachment-0001.html>


More information about the Github-comments mailing list