[Github-comments] [geany/geany] Don't unnecessarily ask whether to close current project (#2178)

elextr notifications at xxxxx
Fri Aug 30 23:50:33 UTC 2019


@ntrel,

Sorry (after the fact) to hijack your PR :cry: feel free to copy the above post to a separate issue it you think its worth it.

This PR I would suggest has the ability to work around it, as you say there are cancel buttons on the remaining dialogs.   

As for OSX testing, I only mentioned it because you mentioned you have been working near OSX specific code, so you might have accidentally changed some of its preconditions, even if you didn't actually touch the OSX stuff itself, and I havn't had the chance to check (and might not recognise it even if I did).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2178#issuecomment-526780055
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190830/d4ec64cc/attachment.html>


More information about the Github-comments mailing list