[Github-comments] [geany/geany] build.c: Fix memory leak & make some small refactorings (#2271)

elextr notifications at xxxxx
Sat Aug 24 00:46:26 UTC 2019


elextr commented on this pull request.



> @@ -817,7 +816,8 @@ static gchar *prepare_run_cmd(GeanyDocument *doc, gchar **working_dir, guint cmd
 	{
 		if (vc->skip_run_script)
 		{
-			utils_free_pointers(2, cmd_string_utf8, working_dir_utf8, NULL);
+			utils_free_pointers(3, cmd_string_utf8, working_dir_utf8,
+				*working_dir, NULL);

Freeing this breaks https://github.com/geany/geany/blob/a70fd97f9c841e47d4df6363c5870dcd3dd48e97/src/build.c#L876 in the caller

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2271#pullrequestreview-279266605
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190823/5991f549/attachment-0001.html>


More information about the Github-comments mailing list