[Github-comments] [geany/geany] build.c: enable the Next/Prev Error menu items only when there are build error messages (#2269)

Nick Treleaven notifications at xxxxx
Thu Aug 22 15:25:54 UTC 2019


**Merge #2268 before this pull**

* Whilst compiling, enable the *Next/Prev Error* menu items only when the first error is found. Before it enabled them for any compiler tab messages.
* The above has been handled in build.c rather than msgwindow.c, as it has more build-related information (and these menu items are already handled there). This allows the `GeanyBuildFixedMenuItems` enum to be moved to build.c, as it doesn't need to be exposed elsewhere - this change depends on #2268.
* Once a build command is complete, `build_menu_update` is called - this pull makes that function only enable *Next/Prev Error* menu items when there actually were error lines.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/2269

-- Commit Summary --

  * build.h: Move GBO_TO_* macros to build.c
  * build.c: Only set next/prev error menu items sensitive on first error
  * Move GeanyBuildFixedMenuItems enum to build.c
  * build_menu_update: Only enable next/prev error items when errors found

-- File Changes --

    M src/build.c (112)
    M src/build.h (42)
    M src/keybindings.c (58)
    M src/msgwindow.c (4)

-- Patch Links --

https://github.com/geany/geany/pull/2269.patch
https://github.com/geany/geany/pull/2269.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2269
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20190822/32e04e19/attachment.html>


More information about the Github-comments mailing list